Skip to content

feat: make acknowledgement context a union of URI and strongRef - #159

Merged
aspiers merged 1 commit into
developfrom
feat/acknowledgement-context-union
Mar 2, 2026
Merged

feat: make acknowledgement context a union of URI and strongRef#159
aspiers merged 1 commit into
developfrom
feat/acknowledgement-context-union

Conversation

@holkexyz

@holkexyz holkexyz commented Mar 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Changes the context field in org.hypercerts.context.acknowledgement from a plain strongRef to a union of org.hypercerts.defs#uri and com.atproto.repo.strongRef
  • Allows consumers to use either a lightweight URI (including AT-URIs) or a content-hash-pinned strong reference for the acknowledgement context

Test plan

  • All existing tests pass (npm run check)
  • SCHEMAS.md regenerated
  • Prettier formatting passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Acknowledgement context now supports both lightweight URI and content-hash verified references for greater flexibility in reference types.
  • Documentation

    • Updated schema documentation to reflect expanded reference capabilities.

Allows context to be either a lightweight URI reference or a
content-hash-pinned strong reference, giving consumers flexibility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Mar 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f4b4fe4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f947b1c and f4b4fe4.

📒 Files selected for processing (2)
  • SCHEMAS.md
  • lexicons/org/hypercerts/context/acknowledgement.json

📝 Walkthrough

Walkthrough

The context property in the org.hypercerts.context.acknowledgement schema changes from accepting only a strong reference to accepting either a URI or a strong reference. Documentation and schema definition are updated to reflect this expanded flexibility.

Changes

Cohort / File(s) Summary
Acknowledgement Context Schema
SCHEMAS.md, lexicons/org/hypercerts/context/acknowledgement.json
Context field updated from single strongRef type to union type supporting both URI and strongRef references. Description expanded to clarify lightweight URI and content-hash verification options.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • aspiers

Poem

🐰 A context grows wise, embracing two ways,
URI light or strong hash through the haze,
References dance in union's embrace,
Flexibility blooms in this schema space! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: converting the acknowledgement context field from a single strongRef type to a union of URI and strongRef types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Lexicon Documentation Sync ✅ Passed The acknowledgement.json lexicon was modified to change the context property to a union type. SCHEMAS.md was regenerated to reflect this change. README.md and ERD.puml do not require updates as acknowledgement is not documented in README.md and ERD.puml tracks entity structures, not property type changes.
Lexicons Styleguide Compliance ✅ Passed The modified org.hypercerts.context.acknowledgement.json file fully complies with the ATProto Lexicon Style Guide.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/acknowledgement-context-union

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aspiers
aspiers merged commit b8c9f7d into develop Mar 2, 2026
5 checks passed
@aspiers
aspiers deleted the feat/acknowledgement-context-union branch March 2, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants