Skip to content

feat: make acknowledgement context a union of URI and strongRef #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aspiers merged 1 commit into from
Mar 2, 2026
Merged

feat: make acknowledgement context a union of URI and strongRef #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions SCHEMAS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,13 @@ Hypercerts-specific lexicons for tracking impact work and claims.

#### Properties

| Property | Type | Required | Description | Comments |
| -------------- | --------- | -------- | ----------------------------------------------------------------------------------------------------------------------------- | ------------------------------------ |
| `subject` | `ref` | ✅ | The record being acknowledged (e.g. an activity, a contributor information record, an evaluation). | |
| `context` | `ref` | ❌ | Context for the acknowledgement (e.g. the collection that includes an activity, or the activity that includes a contributor). | |
| `acknowledged` | `boolean` | ✅ | Whether the relationship is acknowledged (true) or rejected (false). | |
| `comment` | `string` | ❌ | Optional plain-text comment providing additional context or reasoning. | maxLength: 10000, maxGraphemes: 1000 |
| `createdAt` | `string` | ✅ | Client-declared timestamp when this record was originally created. | |
| Property | Type | Required | Description | Comments |
| -------------- | --------- | -------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------ |
| `subject` | `ref` | ✅ | The record being acknowledged (e.g. an activity, a contributor information record, an evaluation). | |
| `context` | `union` | ❌ | Context for the acknowledgement (e.g. the collection that includes an activity, or the activity that includes a contributor). A URI for a lightweight reference or a strong reference for content-hash verification. | |
| `acknowledged` | `boolean` | ✅ | Whether the relationship is acknowledged (true) or rejected (false). | |
| `comment` | `string` | ❌ | Optional plain-text comment providing additional context or reasoning. | maxLength: 10000, maxGraphemes: 1000 |
| `createdAt` | `string` | ✅ | Client-declared timestamp when this record was originally created. | |

---

Expand Down
6 changes: 3 additions & 3 deletions lexicons/org/hypercerts/context/acknowledgement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
"description": "The record being acknowledged (e.g. an activity, a contributor information record, an evaluation)."
},
"context": {
"type": "ref",
"ref": "com.atproto.repo.strongRef",
"description": "Context for the acknowledgement (e.g. the collection that includes an activity, or the activity that includes a contributor)."
"type": "union",
"refs": ["org.hypercerts.defs#uri", "com.atproto.repo.strongRef"],
"description": "Context for the acknowledgement (e.g. the collection that includes an activity, or the activity that includes a contributor). A URI for a lightweight reference or a strong reference for content-hash verification."
},
"acknowledged": {
"type": "boolean",
Expand Down
Loading