Skip to content

fix(login-page): open Terms and Privacy links in a new tab - #127

Merged
aspiers merged 2 commits into
mainfrom
fix/login-legal-links-new-tab
Apr 30, 2026
Merged

fix(login-page): open Terms and Privacy links in a new tab#127
aspiers merged 2 commits into
mainfrom
fix/login-legal-links-new-tab

Conversation

@s-adamantine

@s-adamantine s-adamantine commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Keep users on the in-progress sign-in flow when they click the legal links — the links now carry target="_blank" rel="noopener noreferrer", matching the existing "Powered by" logo link.

Summary by CodeRabbit

  • Bug Fixes

    • Legal document links on the sign-in page no longer interrupt the sign-in flow; Terms of Use and Privacy Policy open in a new browser tab so you can review them without losing progress.
  • Style

    • Link appearance/interaction updated for clearer clickability on the sign-in page.

Keep users on the in-progress sign-in flow when they click the legal
links — the links now carry target="_blank" rel="noopener noreferrer",
matching the existing "Powered by" logo link.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@changeset-bot

changeset-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9ab9cde

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@railway-app

railway-app Bot commented Apr 30, 2026

Copy link
Copy Markdown

🚅 Deployed to the ePDS-pr-127 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/auth-service ◻️ Removed (View Logs) Web Apr 30, 2026 at 5:17 pm
@certified-app/demo ◻️ Removed (View Logs) Web Apr 30, 2026 at 5:17 pm
@certified-app/demo untrusted ◻️ Removed (View Logs) Web Apr 30, 2026 at 5:17 pm
@certified-app/pds-core ◻️ Removed (View Logs) Web Apr 30, 2026 at 5:17 pm

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4b7d9d2f-b7ab-4bf6-9db2-92dc7cb3a725

📥 Commits

Reviewing files that changed from the base of the PR and between 8bf888b and 9ab9cde.

📒 Files selected for processing (1)
  • packages/auth-service/src/routes/login-page.ts
✅ Files skipped from review due to trivial changes (1)
  • packages/auth-service/src/routes/login-page.ts

📝 Walkthrough

Walkthrough

This change updates the ePDS sign-in page so the Terms of Use and Privacy Policy links open in a new browser tab (target="_blank") with rel="noopener noreferrer". A Changeset documenting a patch bump was added.

Changes

Cohort / File(s) Summary
Changeset Documentation
\.changeset/login-legal-links-new-tab.md
Adds a new Changeset entry describing the patch-level change that link behavior on the sign-in page now opens legal pages in a new tab.
Login Page Implementation
packages/auth-service/src/routes/login-page.ts
Login page anchor tags for Terms of Use and Privacy Policy now include target="_blank" and rel="noopener noreferrer". CSS adds cursor: pointer for .terms-link and .powered-by.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • aspiers

Poem

🐇 I hopped to the login gate,
Legal doors now open in a new slate,
No stray clicks will end the flow,
Tabs keep the sign-in ready to go —
A tiny hop, a smoother show.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: opening Terms and Privacy links in a new tab on the login page.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/login-legal-links-new-tab

Review rate limit: 3/5 reviews remaining, refill in 14 minutes and 23 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-127 April 30, 2026 16:41 Destroyed
@coveralls-official

coveralls-official Bot commented Apr 30, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 25178026430

Coverage remained the same at 49.371%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2669
Covered Lines: 1328
Line Coverage: 49.76%
Relevant Branches: 1623
Covered Branches: 791
Branch Coverage: 48.74%
Branches in Coverage %: Yes
Coverage Strength: 4.99 hits per line

💛 - Coveralls

Anchors already default to cursor:pointer; making it explicit on
.terms-link and .powered-by guards against any inherited override
and signals clickability unambiguously.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Apr 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview, Comment Apr 30, 2026 4:51pm

Request Review

@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-127 April 30, 2026 16:50 Destroyed
@railway-app
railway-app Bot temporarily deployed to ePDS / ePDS-pr-126 April 30, 2026 16:50 Destroyed
@sonarqubecloud

Copy link
Copy Markdown

@aspiers
aspiers added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit ea56f77 Apr 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants