Skip to content

fix(login-page): open Terms and Privacy links in a new tab #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aspiers merged 2 commits into from
Apr 30, 2026
Merged

fix(login-page): open Terms and Privacy links in a new tab #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bf888b
fix(login-page): open Terms and Privacy links in a new tab
s-adamantine Apr 30, 2026
9ab9cde
style(login-page): explicit cursor:pointer on legal links and logo
s-adamantine Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/login-legal-links-new-tab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'ePDS': patch
---

Terms of Use and Privacy Policy links on the sign-in page now open in a new tab.

**Affects:** End users

**End users:** clicking Terms of Use or Privacy Policy on the sign-in page no longer navigates away from the in-progress sign-in. The links open in a new tab instead, so you can read the legal page and come back to finish signing in without restarting.
8 changes: 4 additions & 4 deletions packages/auth-service/src/routes/login-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,9 +494,9 @@ export function renderLoginPage(opts: {
opts.initialStep === 'otp' ? 'none' : 'block'
};">By signing in, you agree to ${termsLead} <a href="${escapeHtml(
opts.termsOfServiceUrl as string,
)}" class="terms-link">Terms of Use</a> and <a href="${escapeHtml(
)}" class="terms-link" target="_blank" rel="noopener noreferrer">Terms of Use</a> and <a href="${escapeHtml(
opts.privacyPolicyUrl as string,
)}" class="terms-link">Privacy Policy</a>.</div>`
)}" class="terms-link" target="_blank" rel="noopener noreferrer">Privacy Policy</a>.</div>`
: ''

const hasGoogle = 'google' in socialProviders
Expand Down Expand Up @@ -578,8 +578,8 @@ export function renderLoginPage(opts: {
.step-otp.active { display: block; }
.step-email.hidden { display: none; }
.terms { margin-top: 24px; color: var(--muted-foreground); font-size: 13px; font-weight: 400; line-height: 1.5; text-align: center; }
.terms-link { color: inherit; text-decoration: underline; }
.powered-by { display: flex; align-items: center; justify-content: center; gap: 8px; margin-top: 16px; color: var(--muted-foreground); font-size: 13px; text-decoration: none; }
.terms-link { color: inherit; text-decoration: underline; cursor: pointer; }
.powered-by { display: flex; align-items: center; justify-content: center; gap: 8px; margin-top: 16px; color: var(--muted-foreground); font-size: 13px; text-decoration: none; cursor: pointer; }
.powered-by:hover, .powered-by:focus, .powered-by:visited { color: var(--muted-foreground); text-decoration: none; }
.powered-by .certified-mark { height: 14px; width: auto; display: block; }
/* Recovery-via-backup-email link. Shown by default; trusted clients
Expand Down
Loading