Remove max_prompt_length from experimental BCO#4964
Merged
albertvillanova merged 6 commits intohuggingface:mainfrom Feb 5, 2026
Merged
Remove max_prompt_length from experimental BCO#4964albertvillanova merged 6 commits intohuggingface:mainfrom
albertvillanova merged 6 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Feb 4, 2026
qgallouedec
reviewed
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove max_prompt_length from experimental BCO.
This PR removes the
max_prompt_lengthparameter from the BCO training pipeline, simplifying both the configuration and the tokenization logic.Follow-up to:
Configuration and Argument Cleanup
max_prompt_lengthargument from theBCOConfigclass and its documentation, as well as from all related code paths and warnings. This reduces user confusion and simplifies configuration.Tokenization and Preprocessing Logic
_process_tokensfunction to eliminate prompt truncation based onmax_prompt_length. Now, only the response is truncated if the total sequence exceedsmax_length, and prompt tokenization no longer uses a prompt length limit.max_prompt_lengthin dataset mapping and processing, ensuring consistent use of the new logic across training and evaluation.Example and Script Updates
--max_prompt_lengthfrom CLI arguments, aligning usage examples with the new configuration.Testing updates:
max_prompt_lengthfrom test cases.