Refactor KTO coordinated with DPO [b/N]: Simplify truncation logic#4808
Merged
albertvillanova merged 3 commits intohuggingface:mainfrom Jan 13, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Jan 12, 2026
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor KTO coordinated with DPO [b/N]: Simplify truncation logic.
This PR simplifies the truncation logic by removing
max_prompt_lengthandtruncation_modeparameters, keeping onlymax_length.This simplification makes the KTO trainer significantly easier to use and understand, while maintaining correct truncation behavior.
Follow-up to:
Part of:
Coordinated with DPO refactoring, as discussed with @qgallouedec :
Key Changes
KTOConfig
KTOTrainer
Simplified _process_tokens() function:
Trainer Initialization:
Tests