Skip to content

Remove max_prompt_length from experimental PRM#4963

Merged
albertvillanova merged 4 commits intohuggingface:mainfrom
albertvillanova:rm-max-prompt-length-prm
Feb 5, 2026
Merged

Remove max_prompt_length from experimental PRM#4963
albertvillanova merged 4 commits intohuggingface:mainfrom
albertvillanova:rm-max-prompt-length-prm

Conversation

@albertvillanova
Copy link
Member

Remove max_prompt_length from experimental PRM.

This PR removes support for the max_prompt_length parameter from the PRM trainer code and its associated tests.

Follow-up to:

Key changes include:

Core code and configuration cleanup:

  • Removed the max_prompt_length parameter and its logic from the PRMConfig class, the PRMTrainer.tokenize_row method, and related configuration and function signatures.
  • Updated the truncation logic in tokenize_row removing prompt-specific truncation.

Testing updates:

  • Removed all uses of max_prompt_length from test cases and deleted the test for prompt truncation, as this functionality is no longer supported.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@albertvillanova albertvillanova merged commit 35bcab1 into huggingface:main Feb 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants