-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Fix TF CTC tests #21606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TF CTC tests #21606
Conversation
| default_batch_size = self.model_tester.batch_size | ||
| self.model_tester.batch_size = 2 | ||
| super().test_dataset_conversion() | ||
| super().test_keras_fit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ninja copy paste hehe
| self.assertIsNotNone(model) | ||
|
|
||
| # We override here as passing a full batch of 13 samples results in OOM errors for CTC | ||
| def test_dataset_conversion(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one, in TFHubertModelTest, was the issue. Since it did not have the lower batch size treatment as in the other TF CTC tests, I'm assuming this is the fix.
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me. But would like @amyeroberts to take a look (even afterward) to check if any merged commit cause this issue. These tests run with tiny models, usually don't have such memory issue. And we didn't have this failure previously (right?).
|
@ydshieh before @amyeroberts work in #21502 these tests had no overwrite, correct. However, see the note in Amy's PR -- the labels were not correctly handled, which meant that |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
|
Thanks for the fix @gante ! @ydshieh Yes, Joao's correct. There's three different cases where the state of the tests changed:
|
What does this PR do?
(see title)