Skip to content

Fix TF CTC tests #21606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gante merged 2 commits into from
Feb 13, 2023
Merged

Fix TF CTC tests #21606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd18e0
smaller test
gante Feb 13, 2023
a20dedd
fix ctc tests
gante Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions tests/models/hubert/test_modeling_tf_hubert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,20 @@ def test_model_from_pretrained(self):
model = TFHubertModel.from_pretrained("facebook/hubert-base-ls960")
self.assertIsNotNone(model)

# We override here as passing a full batch of 13 samples results in OOM errors for CTC
def test_dataset_conversion(self):
Copy link
Contributor Author

@gante gante Feb 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one, in TFHubertModelTest, was the issue. Since it did not have the lower batch size treatment as in the other TF CTC tests, I'm assuming this is the fix.

default_batch_size = self.model_tester.batch_size
self.model_tester.batch_size = 2
super().test_dataset_conversion()
self.model_tester.batch_size = default_batch_size

# We override here as passing a full batch of 13 samples results in OOM errors for CTC
def test_keras_fit(self):
default_batch_size = self.model_tester.batch_size
self.model_tester.batch_size = 2
super().test_keras_fit()
self.model_tester.batch_size = default_batch_size


@require_tf
class TFHubertRobustModelTest(TFModelTesterMixin, unittest.TestCase):
Expand Down Expand Up @@ -431,20 +445,18 @@ def test_resize_tokens_embeddings(self):
def test_model_common_attributes(self):
pass

@slow
def test_model_from_pretrained(self):
model = TFHubertModel.from_pretrained("facebook/hubert-large-ls960-ft")
self.assertIsNotNone(model)

# We override here as passing a full batch of 13 samples results in OOM errors for CTC
# TODO: fix me
@unittest.skip(reason="Crashing on CI, temporarily skipped")
def test_dataset_conversion(self):
default_batch_size = self.model_tester.batch_size
self.model_tester.batch_size = 2
super().test_dataset_conversion()
self.model_tester.batch_size = default_batch_size

@slow
def test_model_from_pretrained(self):
model = TFHubertModel.from_pretrained("facebook/hubert-large-ls960-ft")
self.assertIsNotNone(model)

# We override here as passing a full batch of 13 samples results in OOM errors for CTC
def test_keras_fit(self):
default_batch_size = self.model_tester.batch_size
Expand Down
4 changes: 2 additions & 2 deletions tests/models/wav2vec2/test_modeling_tf_wav2vec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ def test_dataset_conversion(self):
def test_keras_fit(self):
default_batch_size = self.model_tester.batch_size
self.model_tester.batch_size = 2
super().test_dataset_conversion()
super().test_keras_fit()
Copy link
Contributor Author

@gante gante Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ninja copy paste hehe

self.model_tester.batch_size = default_batch_size


Expand Down Expand Up @@ -528,7 +528,7 @@ def test_dataset_conversion(self):
def test_keras_fit(self):
default_batch_size = self.model_tester.batch_size
self.model_tester.batch_size = 2
super().test_dataset_conversion()
super().test_keras_fit()
self.model_tester.batch_size = default_batch_size


Expand Down