Skip to content

Conversation

@gante
Copy link
Contributor

@gante gante commented Feb 13, 2023

What does this PR do?

@gante gante requested a review from sgugger February 13, 2023 11:41
@gante
Copy link
Contributor Author

gante commented Feb 13, 2023

cc @amyeroberts

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 13, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - approved in case you want to merge quickly.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit 4be75e9 into huggingface:main Feb 13, 2023
@gante gante deleted the hubert_test branch February 13, 2023 15:10
@susnato
Copy link
Contributor

susnato commented Feb 13, 2023

@gante is this issue fixed? I am asking because I am still getting this error here in this PR . I did rebase to upstream/main .

@gante gante restored the hubert_test branch February 13, 2023 15:57
@gante
Copy link
Contributor Author

gante commented Feb 13, 2023

@susnato see #21606 (I skipped the wrong one here)

@susnato
Copy link
Contributor

susnato commented Feb 14, 2023

Hi @gante thanks for the fix but now there seems to be a new issue popping up regarding that same model,

tests/models/hubert/test_modeling_tf_hubert.py::TFHubertRobustModelTest::test_keras_fit

This test is failing in the same PR I mentioned above. I did rebase before pushing.

@gante gante deleted the hubert_test branch May 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants