[Tests] Improve test_attention_outputs #20701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2022 11:33
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Dec 9, 2022
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Thanks! Yeah, it's better, but we should skip the tests instead of just return - so we can see they are skipped in the CI report.
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* Improve tests * Improve TF tests * Apply suggestion * Fix test Co-authored-by: Niels Rogge <[email protected]>
gsarti
added a commit
to gsarti/transformers
that referenced
this pull request
Dec 16, 2022
… add_get_encoder_decoder_fsmt * 'main' of ssh://github.com/huggingface/transformers: (1433 commits) Add Universal Segmentation class + mapping (huggingface#20766) Stop calling expand_1d on newer TF versions (huggingface#20786) Fix object detection2 (huggingface#20798) [Pipeline] skip feature extraction test if in `IMAGE_PROCESSOR_MAPPING` (huggingface#20790) Recompile `apex` in `DeepSpeed` CI image (huggingface#20788) Move convert_to_rgb to image_transforms module (huggingface#20784) Generate: use `GenerationConfig` as the basis for `.generate()` parametrization (huggingface#20388) Install video dependency for pipeline CI (huggingface#20777) Fixing object detection with `layoutlm` (huggingface#20776) [Pipeline] fix failing bloom `pipeline` test (huggingface#20778) Patch for FlanT5-XXL 8bit support (huggingface#20760) Install vision for TF pipeline tests (huggingface#20771) Even more validation. (huggingface#20762) Add Swin backbone (huggingface#20769) Install `torch-tensorrt 1.3.0` for DeepSpeed CI (huggingface#20764) Replaces xxx_required with requires_backends (huggingface#20715) [CI-Test] Fixes but also skips the mT5 tests (huggingface#20755) Fix attribute error problem (huggingface#20765) [Tests] Improve test_attention_outputs (huggingface#20701) Fix missing `()` in some usage of `is_flaky` (huggingface#20749) ...
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed several vision models overwrite
test_attention_outputs, but we have ahas_attentionsflag exactly for this purpose.Hence, I've adapted the test in
test_modeling_common.pyandtest_modeling_tf_common.py to improve this.