[Tests] Improve flax test_attention_outputs #21486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sanchit-gandhi
approved these changes
Feb 10, 2023
Contributor
sanchit-gandhi
left a comment
sanchit-gandhi
left a comment
There was a problem hiding this comment.
LGTM, thanks @Shubhamai! cc @ydshieh for info
ydshieh
approved these changes
Feb 10, 2023
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Thank you. It turns out that attention is not all we need 😆
sgugger
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A copy of #20701 by NielsRogge for making corresponding changes in flax. These changes are also necessary for passing tests in flax convnext implementation PR.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sanchit-gandhi