Fix object detection2 #20798
Merged
Fix object detection2 #20798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
NielsRogge
approved these changes
Dec 16, 2022
Contributor
NielsRogge
left a comment
NielsRogge
left a comment
There was a problem hiding this comment.
Thanks, looks great!
Since when is LayoutLM supported by the object detection pipeline? :D
Contributor
Author
|
gsarti
added a commit
to gsarti/transformers
that referenced
this pull request
Dec 16, 2022
… add_get_encoder_decoder_fsmt * 'main' of ssh://github.com/huggingface/transformers: (1433 commits) Add Universal Segmentation class + mapping (huggingface#20766) Stop calling expand_1d on newer TF versions (huggingface#20786) Fix object detection2 (huggingface#20798) [Pipeline] skip feature extraction test if in `IMAGE_PROCESSOR_MAPPING` (huggingface#20790) Recompile `apex` in `DeepSpeed` CI image (huggingface#20788) Move convert_to_rgb to image_transforms module (huggingface#20784) Generate: use `GenerationConfig` as the basis for `.generate()` parametrization (huggingface#20388) Install video dependency for pipeline CI (huggingface#20777) Fixing object detection with `layoutlm` (huggingface#20776) [Pipeline] fix failing bloom `pipeline` test (huggingface#20778) Patch for FlanT5-XXL 8bit support (huggingface#20760) Install vision for TF pipeline tests (huggingface#20771) Even more validation. (huggingface#20762) Add Swin backbone (huggingface#20769) Install `torch-tensorrt 1.3.0` for DeepSpeed CI (huggingface#20764) Replaces xxx_required with requires_backends (huggingface#20715) [CI-Test] Fixes but also skips the mT5 tests (huggingface#20755) Fix attribute error problem (huggingface#20765) [Tests] Improve test_attention_outputs (huggingface#20701) Fix missing `()` in some usage of `is_flaky` (huggingface#20749) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20776 better.
Reverts the previous PR.
The previous model was using a mix of LayoutLM and LayoutLMv2 leading to a bit of madness. The previous fix was wrong
because it made other pipelines try to load the feature extractor which might not have existed :(.
This fixes differently, by using another new models, and fixing it's config too.
Narsil/layoutlmv3-finetuned-funsdis a fork ofnielsr/layoutlmv3-finetuned-funsdwith thetokenizer_config.jsonfixed (to not use a Roberta tokenizer, but it's proper LayoutLMv3Tokenizer).Also modified the README.md to include examples in the widget, and force the pipeline_tag to be
object-detection.https://huggingface.co/Narsil/layoutlmv3-finetuned-funsd
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.