Add default model_kwargs to Generation Tester#482
Conversation
|
@ankurneog LGTM but you need to apply the code formater too: |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
@regisss : Thanks, I had already run the formatter before upload. (conda_qnpu1) (conda_qnpu1) (anneog_fix_beamsearch_tests) anneog@anneog-vm-u20:optimum-habana $ make style |
|
@ankurneog Weird. Can you let me know the versions of |
|
(conda_qnpu1) (conda_qnpu1) (anneog_fix_beamsearch_tests) anneog@anneog-vm-u20:optimum-habana $ pip list |grep black |
regisss
left a comment
There was a problem hiding this comment.
Those are the same versions as the ones used in the test, very strange... In my environment, I do get a change that I added as a comment below. Let's modify this and then I'll merge!
6c6fe6a to
9e2bdf9
Compare
|
@ankurneog Can we close #470, #448 and #446? |
These are fixes for issues caught while executing the transformers tests. The issues are captured in #445 and
#446
Addressed based on suggestion give here : #470 (comment)
@regisss : please help with the review
TCs impacted ( listed for t5 but these are common TCs impacting all language models)
==============================================================
FAILED test_modeling_t5.py::T5ModelTest::test_beam_search_generate - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_beam_search_generate_dict_output - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_beam_search_generate_dict_outputs_use_cache - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_constrained_beam_search_generate - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_constrained_beam_search_generate_dict_output - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_greedy_generate - KeyError: 'bucket_size'
FAILED test_modeling_t5.py::T5ModelTest::test_greedy_generate_dict_outputs - KeyError: 'bucket_size'
FAILED test_modeling_t5.py::T5ModelTest::test_greedy_generate_dict_outputs_use_cache - KeyError: 'bucket_size'
FAILED test_modeling_t5.py::T5ModelTest::test_sample_generate - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_sample_generate_dict_output - KeyError: 'limit_hpu_graphs'