Fix KeyErrors for attributes not available in model_kwargs#470
Fix KeyErrors for attributes not available in model_kwargs#470ankurneog wants to merge 2 commits into
Conversation
|
Status After the fixes : (conda_qnpu1) (anneog_fix_bucket_size) anneog@anneog-vm-u20:t5 $ python -m pytest -vs test_modeling_t5.py test_modeling_t5.py::T5ModelTest::test_assisted_decoding_matches_greedy_search SKIPPED (test is slow)
|
|
@ankurneog I took a closer look at these tests. What they do is to basically compare the outputs of generation with a given decoding strategy (e.g. beam search) calling The issue here is that the Now, users should never call
|
These are fixes for issues caught while executing the transformers tests. The issues are captured in #445 and #446
TCs impacted ( listed for t5 but these are common TCs impacting all language models)
==============================================================
FAILED test_modeling_t5.py::T5ModelTest::test_beam_search_generate - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_beam_search_generate_dict_output - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_beam_search_generate_dict_outputs_use_cache - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_constrained_beam_search_generate - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_constrained_beam_search_generate_dict_output - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_greedy_generate - KeyError: 'bucket_size'
FAILED test_modeling_t5.py::T5ModelTest::test_greedy_generate_dict_outputs - KeyError: 'bucket_size'
FAILED test_modeling_t5.py::T5ModelTest::test_greedy_generate_dict_outputs_use_cache - KeyError: 'bucket_size'
FAILED test_modeling_t5.py::T5ModelTest::test_sample_generate - KeyError: 'limit_hpu_graphs'
FAILED test_modeling_t5.py::T5ModelTest::test_sample_generate_dict_output - KeyError: 'limit_hpu_graphs'
@regisss : Please help with the review.