Skip to content

fix beam search transformers test, failing with KeyError: 'limit_hpu_graphs'#448

Closed
kalyanjk wants to merge 1 commit into
huggingface:mainfrom
kalyanjk:fix-unit-tests-beam-search
Closed

fix beam search transformers test, failing with KeyError: 'limit_hpu_graphs'#448
kalyanjk wants to merge 1 commit into
huggingface:mainfrom
kalyanjk:fix-unit-tests-beam-search

Conversation

@kalyanjk
Copy link
Copy Markdown
Contributor

@kalyanjk kalyanjk commented Oct 4, 2023

What does this PR do?

Fixes #445

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@kalyanjk
Copy link
Copy Markdown
Contributor Author

kalyanjk commented Oct 4, 2023

please review @dvarshney-habana and @regisss
@ankurneog please test the changes.

@ankurhabana
Copy link
Copy Markdown
Contributor

@kalyanjk : Did you try executing the test with the steps mentioned in the issue, if so can you paste the results here ?

@kalyanjk
Copy link
Copy Markdown
Contributor Author

kalyanjk commented Oct 4, 2023

@kalyanjk : Did you try executing the test with the steps mentioned in the issue, if so can you paste the results here ?

Tests passed
image

@kalyanjk kalyanjk changed the title fix for - beam search transformers test, failing with KeyError: 'lim… fix for - beam search transformers test, failing with KeyError: 'limit_hpu_graphs' Oct 4, 2023
@kalyanjk kalyanjk changed the title fix for - beam search transformers test, failing with KeyError: 'limit_hpu_graphs' fix beam search transformers test, failing with KeyError: 'limit_hpu_graphs' Oct 4, 2023
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalyanjk limit_hpu_graphs should already be in the generation config of the model and thus in the model_kwargs. I think it's rather an issue of adapt_transformers_to_gaudi not being called in https://github.com/huggingface/optimum-habana/blob/main/tests/transformers/tests/generation/test_utils.py.

@ankurneog
Copy link
Copy Markdown
Contributor

This can be closed. Issue fixed via : #482

@regisss regisss closed this Oct 25, 2023
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beach search transformers test cases are failing with KeyError: 'limit_hpu_graphs'

6 participants