reverting disable FusedRMSNorm for training (#343) since rmsnorm issu…#449
Merged
Conversation
…e is fixed in 1.12
|
The documentation is not available anymore as the PR was closed or merged. |
regisss
reviewed
Oct 8, 2023
Collaborator
regisss
left a comment
regisss
left a comment
There was a problem hiding this comment.
LGTM
We should also do it for T5:
Collaborator
|
@hsubramony Can you also open a PR to apply the same change to T5 please? |
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
…ace#449) Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e is fixed in 1.12
What does this PR do?
Fixes # (issue)
Before submitting