Skip to content

Use profiler in text-generation-pipeline#2154

Merged
regisss merged 1 commit into
huggingface:mainfrom
HabanaAI:dev/pbielak/use-profiler-in-text-generation-pipeline
Jul 17, 2025
Merged

Use profiler in text-generation-pipeline#2154
regisss merged 1 commit into
huggingface:mainfrom
HabanaAI:dev/pbielak/use-profiler-in-text-generation-pipeline

Conversation

@pbielak
Copy link
Copy Markdown
Collaborator

@pbielak pbielak commented Jul 17, 2025

What does this PR do?

The examples in text-generation-pipeline fail due to profiler args still being passed separately instead of a single profiler argument. This commit updates the creation of the profiler and fixes the arguments passed to self.model.generate(...).

The examples in `text-generation-pipeline` fail due to profiler args
still being passed separately instead of a single `profiler` argument.
This commit updates the creation of the profiler and fixes the arguments
passed to `self.model.generate(...)`.
@pbielak pbielak requested a review from regisss as a code owner July 17, 2025 13:09
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@pbielak
Copy link
Copy Markdown
Collaborator Author

pbielak commented Jul 17, 2025

Needs to be cherry-picked to v1.19-release

@astachowiczhabana
Copy link
Copy Markdown
Collaborator

Thx @pbielak. Looks like regression introduced by #1931

@astachowiczhabana
Copy link
Copy Markdown
Collaborator

Hi @regisss Can we merge this?

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 061aefa into huggingface:main Jul 17, 2025
2 of 5 checks passed
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Jul 17, 2025

Needs to be cherry-picked to v1.19-release

Done

@pbielak pbielak deleted the dev/pbielak/use-profiler-in-text-generation-pipeline branch July 17, 2025 13:51
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
…ace#449)

Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants