Skip to content

disable FusedRMSNorm for training#343

Merged
regisss merged 1 commit into
mainfrom
hsubramony_FusedRMSNorm_disable
Aug 16, 2023
Merged

disable FusedRMSNorm for training#343
regisss merged 1 commit into
mainfrom
hsubramony_FusedRMSNorm_disable

Conversation

@hsubramony
Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@hsubramony hsubramony requested review from libinta and mandy-li August 16, 2023 19:56
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 16, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit 58eabc5 into main Aug 16, 2023
@regisss regisss deleted the hsubramony_FusedRMSNorm_disable branch August 16, 2023 22:46
schoi-habana pushed a commit that referenced this pull request Aug 23, 2023
hsubramony added a commit that referenced this pull request Oct 4, 2023
mandy-li pushed a commit that referenced this pull request Oct 10, 2023
#449)

reverting disable FusedRMSNorm for training (#343) since rmsnorm issue is fixed in 1.12
ranzhejiang pushed a commit to ranzhejiang/optimum-habana that referenced this pull request Oct 17, 2025
git-subtree-dir: LLaMA-Factory
git-subtree-split: 089b8bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants