Profiling improvements#1931
Merged
Merged
Conversation
Collaborator
ugolowic
commented
Apr 14, 2025
ugolowic
commented
- Refactor HabanaProfile so that it can be used more than once
- Add option for the user to collect profiling in GaudiTrainer's eval
- In text-generation, user can now select whether a profiling step means generating one token or one sequence
- Added integration and unit tests for HabanaProfile
ugolowic
requested review from
bhargaveede,
regisss,
ssarkar2 and
vivekgoe
as code owners
|
The code quality check failed, please run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ugolowic
force-pushed
the
dev/ugolowicz/new-profiling
branch
from
b76bb15 to
1289ede
Compare
Contributor
|
@ugolowic , Please resolve conflicts as they come up. |
ugolowic
force-pushed
the
dev/ugolowicz/new-profiling
branch
from
1289ede to
4e1d69b
Compare
Profiling can be started more than once, at different points in the course of running an example, e.g. both during training and during evaluation. Signed-off-by: Urszula Golowicz <urszula.golowicz@intel.com>
Update arguments, examples, and classes to enable using profiling in both train and eval stage of a run. Signed-off-by: Urszula Golowicz <urszula.golowicz@intel.com>
Signed-off-by: Urszula Golowicz <urszula.golowicz@intel.com>
Add the option to profile whole sequences in text-generation. Use --profile_whole_sequences boolean arg to enable it. Signed-off-by: Urszula Golowicz <urszula.golowicz@intel.com>
ugolowic
force-pushed
the
dev/ugolowicz/new-profiling
branch
from
4e1d69b to
018158a
Compare
3 tasks
|
The code quality check failed, please run |
Collaborator
|
Fixed merge conflicts, @emascarenhas @regisss can you please approve? |
regisss
reviewed
Jul 7, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
added a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 8, 2025
astachowiczhabana
added a commit
that referenced
this pull request
Jul 8, 2025
regisss
approved these changes
Jul 10, 2025
astachowiczhabana
added a commit
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Urszula Golowicz <urszula.golowicz@intel.com> Co-authored-by: Adam Stachowicz <astachowicz@habana.ai> Co-authored-by: Adam Stachowicz <105052242+astachowiczhabana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.