Skip to content

chore(docstrings): fixing deprecated root argument description in LeRobotDataset class#3035

Merged
imstevenpmwork merged 4 commits intomainfrom
fix/dataset-docstrings
Feb 27, 2026
Merged

chore(docstrings): fixing deprecated root argument description in LeRobotDataset class#3035
imstevenpmwork merged 4 commits intomainfrom
fix/dataset-docstrings

Conversation

@CarolinePascal
Copy link
Collaborator

Type / Scope

  • Type: Chore
  • Scope: LeRobotDataset

Summary / Motivation

Updates the description of the root parameter in LeRobotDataset class. Since LeRobotDataset v.2.0, root directly points to the folder in which the dataset is stored. No repo_id will be added to the provided path.

Related issues

What changed

  • LeRobotDataset docstrings.

How was this tested (or how to run locally)

N/A

Checklist (required before merge)

  • Linting/formatting run (pre-commit run -a)
  • All tests pass locally (pytest)
  • Documentation updated
  • CI is green

Reviewer notes

  • Anything the reviewer should focus on (performance, edge-cases, specific files) or general notes.
  • Anyone in the community is free to review the PR.

Copilot AI review requested due to automatic review settings February 26, 2026 17:32
@github-actions github-actions bot added the dataset Issues regarding data inputs, processing, or datasets label Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the docstring for the root parameter in the LeRobotDataset class to accurately reflect the behavior change introduced in v2.0. The documentation previously stated that datasets would be stored under root/repo_id, but since v2.0, the root parameter points directly to the dataset folder without appending repo_id.

Changes:

  • Updated the root parameter documentation in LeRobotDataset.__init__ to clarify that it represents the direct path to the dataset folder, not a parent directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added configuration Problems with configuration files or settings examples Issues related to the examples labels Feb 26, 2026
@imstevenpmwork imstevenpmwork self-requested a review February 27, 2026 17:20
Copy link
Collaborator

@imstevenpmwork imstevenpmwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imstevenpmwork imstevenpmwork merged commit 8fff0fd into main Feb 27, 2026
7 checks passed
@imstevenpmwork imstevenpmwork deleted the fix/dataset-docstrings branch February 27, 2026 17:22
xianglunkai pushed a commit to xianglunkai/lerobot that referenced this pull request Feb 28, 2026
…eRobotDataset class (huggingface#3035)

* chore(docstrings): fixing deprecated `root` argument docstrings in LeRobotDataset class

* chore(draccus): updating draccus CLI help

* chore(revert): reverting changes in lerobot_dataset_viz.py

---------

Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
sorelferris pushed a commit to sorelferris/lerobot that referenced this pull request Mar 1, 2026
…eRobotDataset class (huggingface#3035)

* chore(docstrings): fixing deprecated `root` argument docstrings in LeRobotDataset class

* chore(draccus): updating draccus CLI help

* chore(revert): reverting changes in lerobot_dataset_viz.py

---------

Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
@CarolinePascal CarolinePascal linked an issue Mar 3, 2026 that may be closed by this pull request
2 tasks
LePao1 pushed a commit to LePao1/lerobot that referenced this pull request Mar 7, 2026
…eRobotDataset class (huggingface#3035)

* chore(docstrings): fixing deprecated `root` argument docstrings in LeRobotDataset class

* chore(draccus): updating draccus CLI help

* chore(revert): reverting changes in lerobot_dataset_viz.py

---------

Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration Problems with configuration files or settings dataset Issues regarding data inputs, processing, or datasets examples Issues related to the examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting episodes by lerobot_edit_dataset fails when root is used

4 participants