chore(root): fixing root semantics in convert_dataset script#3073
Merged
imstevenpmwork merged 2 commits intomainfrom Mar 4, 2026
Merged
chore(root): fixing root semantics in convert_dataset script#3073imstevenpmwork merged 2 commits intomainfrom
root semantics in convert_dataset script#3073imstevenpmwork merged 2 commits intomainfrom
Conversation
github-actions
bot
added
the
dataset
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the convert_dataset_v21_to_v30 conversion script so the --root argument matches current dataset path semantics: root is the dataset directory itself (no longer a parent directory that gets repo_id appended).
Changes:
- Adjust
--roothandling to treat the provided path as the dataset root directory (no/repo_idsuffix). - Clarify path semantics in the script’s usage docstring.
- Update the CLI help text for
--rootto mention the default location.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s1lent4gnt
reviewed
Mar 3, 2026
s1lent4gnt
previously approved these changes
Mar 3, 2026
Member
s1lent4gnt
left a comment
s1lent4gnt
left a comment
There was a problem hiding this comment.
Thank you for checking this, LGTM!
Signed-off-by: Caroline Pascal <caroline8.pascal@gmail.com>
LePao1
pushed a commit
to LePao1/lerobot
that referenced
this pull request
Mar 7, 2026
…ngface#3073) * fix(root): fixing root semantincs in convert_dataset script * fix(\): fixing command syntax in dataset conversion script Signed-off-by: Caroline Pascal <caroline8.pascal@gmail.com> --------- Signed-off-by: Caroline Pascal <caroline8.pascal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type / Scope
convert_dataset_v21_to_v30scriptSummary / Motivation
Following up on #3035, this PR fixes the interpretation of the
rootargument in theconvert_dataset_v21_to_v30script.Related issues
What changed
rootnow defines the exact dataset folder containing meta/, data/, videos/.How was this tested (or how to run locally)
Successfully converted a local dataset using the
--rootargument.Checklist (required before merge)
pre-commit run -a)pytest)Reviewer notes