Correctly resolve root path when merging local datasets in dataset-tools#3030
Closed
s1lent4gnt wants to merge 2 commits intomainfrom
Closed
Correctly resolve root path when merging local datasets in dataset-tools#3030s1lent4gnt wants to merge 2 commits intomainfrom
s1lent4gnt wants to merge 2 commits intomainfrom
Conversation
imstevenpmwork
approved these changes
Feb 26, 2026
Collaborator
imstevenpmwork
left a comment
imstevenpmwork
left a comment
There was a problem hiding this comment.
LGTM, but this might cause some issues in windows due to the \\
4 tasks
Collaborator
|
Relevant: #2552 |
Collaborator
|
This will be addressed in: #3035 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2369, Thanks @suessmann for the fix!