fix(dataset-tools): unable to merge local datasets in cache due to a …#2369
Closed
suessmann wants to merge 1 commit intohuggingface:mainfrom
Closed
fix(dataset-tools): unable to merge local datasets in cache due to a …#2369suessmann wants to merge 1 commit intohuggingface:mainfrom
suessmann wants to merge 1 commit intohuggingface:mainfrom
Conversation
…bug in the loading
Member
|
Hey @suessmann, thanks for the fix! One thing — Path(cfg.root) will raise TypeError when cfg.root is None. Small fix: datasets = [
LeRobotDataset(repo_id, root=Path(cfg.root) / repo_id if cfg.root else None)
for repo_id in cfg.operation.repo_ids
] |
Member
|
Superseded by #2369, Thanks @suessmann for the bug report and the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
When using local root, the
lerobot-edit-datasetwith--operation.type=mergereturned theFileNotFoundError. This was due to the fact that when specifying root to load a dataset in the generator[LeRobotDataset(repo_id, root=Path(cfg.root) for repo_id in cfg.operation.repo_ids], the root to the exact dataset was not actually passed.This PR fixes that by adding
[...] root=Path(cfg.root) / repo_id) for repo_id in [...].How it was tested
Just run the merge and it worked, unlike before.
How to checkout & try? (for the reviewer)
Try merging with local root, such as