Performance metrics #1753
Merged
Performance metrics #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add in offline baseline code * Update competition/track-2/train/train.py * Update competition/track-2/train/train.py * Fix unassigned file variable. * Removed unused code. Co-authored-by: Tucker <[email protected]> Co-authored-by: adaickalavan <[email protected]>
Closed
1 task
Gamenot
reviewed
Dec 2, 2022
Gamenot
requested changes
Dec 6, 2022
saulfield
approved these changes
Dec 12, 2022
| self._records[self._cur_scen][agent_name].record.counts = _add_dataclass( | ||
| counts, | ||
| self._records[self._cur_scen][agent_name].record.counts | ||
| ) |
There was a problem hiding this comment.
I have mixed feelings about this approach. Though the immutability is nice, it seems like a bit of a burdensome way to maintain state. Creating a new dict and dataclass each step also seems inefficient. I don't think it's too critical as long as the performance is ok though.
Gamenot
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metricsenv wrapper is introduced to compute agents' performance metrics.CountsandCosts, to facilitate scalability, understandability, and to prevent accidental erroneous modifications.