Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Completion metric #1748

Closed
1 task done
Gamenot opened this issue Nov 25, 2022 · 1 comment · Fixed by #1753
Closed
1 task done

Fix Completion metric #1748

Gamenot opened this issue Nov 25, 2022 · 1 comment · Fixed by #1753

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented Nov 25, 2022 •
edited by Adaickalavan
Loading

  • Base completion on successfully reaching goal of scenario.
@Adaickalavan
Copy link
Member

In PR #1753 , the completion metric is now computed as the proportion of successfully completed scenarios (i.e., goal_achieved / number_of_episodes).

SMARTS/smarts/env/wrappers/metrics.py

Lines 255 to 256 in 3dedf1c

def _completion(counts: Counts) -> float:
return counts.goals / counts.episodes

@Adaickalavan Adaickalavan linked a pull request Nov 28, 2022 that will close this issue
Performance metrics #1753
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Performance metrics huawei-noah/SMARTS
2 participants
@Gamenot @Adaickalavan