Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SUMO to 1.12.0 #1751

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Upgrade SUMO to 1.12.0 #1751

merged 5 commits into from
Nov 28, 2022

Conversation

saulfield
Copy link
Contributor

Closes #1717

Adaickalavan
Adaickalavan reviewed Nov 25, 2022
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@Gamenot
Copy link
Collaborator

Gamenot commented Nov 25, 2022

Interesting that test_map failed https://github.com/huawei-noah/SMARTS/actions/runs/3549894566/jobs/5962761264#step:5:588

I wonder how the new version of SUMO had an effect on it.

@saulfield
Copy link
Contributor Author

Interesting that test_map failed https://github.com/huawei-noah/SMARTS/actions/runs/3549894566/jobs/5962761264#step:5:588

I wonder how the new version of SUMO had an effect on it.

It looks like it's a small numerical difference:

>       assert db == 134.01
E       assert 134.0 == 134.01

smarts/core/tests/test_map.py:135: AssertionError

I can change the assert from an equality to math.isclose(). It's a bit odd that this passes locally for me though.

Gamenot
Gamenot approved these changes Nov 25, 2022
View reviewed changes
smarts/core/tests/test_map.py Outdated
@@ -132,7 +132,7 @@ def test_sumo_map(sumo_scenario):
rpt = RoadMap.Route.RoutePoint(pt=point)
rendpt = RoadMap.Route.RoutePoint(pt=Point(198, 65.20))
db = route.distance_between(rpt, rendpt)
assert db == 134.01
assert math.isclose(db, 134.01)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might need a bit more tweaking since this still resolves false.

@saulfield saulfield merged commit d28758c into develop Nov 28, 2022
@saulfield saulfield deleted the saul/upgrade-sumo branch November 28, 2022 19:22
@saulfield saulfield mentioned this pull request Nov 28, 2022
Closed
@Adaickalavan
Copy link
Member

Adaickalavan commented Dec 5, 2022 •
edited
Loading

@saulfield

@saulfield saulfield mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adaickalavan Adaickalavan Adaickalavan approved these changes

@Gamenot Gamenot Gamenot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saulfield @Gamenot @Adaickalavan