Suppress TraCI Error on simulationStep #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
reviewed
Dec 7, 2022
Comment on lines
+472
to
+473
| with suppress_output(stderr=False): | ||
| self._traci_conn.simulationStep(self._cumulative_sim_seconds) |
There was a problem hiding this comment.
Is sumo outputting errors on stdout for some reason?
There was a problem hiding this comment.
Yes, this error is coming through stdout.
There was a problem hiding this comment.
Weird. I suppose they consider that it is not crashing. Perhaps it is just reasonable to not output the sumo stdout logs because we have it set to log to a file anyway.
Gamenot
approved these changes
Dec 8, 2022
Adaickalavan
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1751 (comment) and #1155, SUMO versions after 1.10.0 throw an error in the first call to
simulationStep()after callingvehicle.remove(). After investigating this, I couldn't find a cause for the error, and it did not seem to impact the simulation, so I am suppressing the error message.For future reference, this error can be reproduced reliably by running: