Competition agent integration with zoo #1724
Conversation
…ompetition_agent fetch newest comp-1 branch
qianyi-sun
requested review from
Gamenot,
saulfield,
qianyi-sun and
Adaickalavan
|
Currently only comp-1 branch has the competition folder and the require policies/requirements. My work is based on that and merging directly into develop may cause some issues I think. Maybe we should try to merge comp-1 into develop first? |
It is possible that comp-1 does not get merged in. This agent, however, lets us run competition agents directly as were created in the competition so that we will not have to modify them. |
AisenGinn
requested review from
saulfield
and removed request for
Gamenot and
qianyi-sun
| register( | ||
| "competition_agent-v0", | ||
| entry_point=competition_entry, | ||
| policy_path=os.path.join(root_path, "competition/track1/submission"), |
There was a problem hiding this comment.
This is the default but we will want to remove this default before merging.
There was a problem hiding this comment.
I think we will want to either do it by referencing the winning agents like "competition_aid_v0", "competition_vcr_v0", and "competition_tju-fanta_v0". or by removing a default to force policy_path to be specified when initializing an agent.
zoo/policies/__init__.py
Outdated
| while sub_env_path in sys.path: | ||
| sys.path.remove(sub_env_path) # prevent duplicate path remain in sys.path |
There was a problem hiding this comment.
How does this end up in the path?
There was a problem hiding this comment.
The sub_env_path is appended when the dependency is installed.
zoo/policies/__init__.py
Outdated
| while policy_path in sys.path: | ||
| sys.path.remove(policy_path) # prevent duplicate path remain in sys.path |
There was a problem hiding this comment.
Why is it necessary to remove duplicates like this?
There was a problem hiding this comment.
There are some users that insert the submission path inside the policy.py they wrote, some do not. If they insert there will be two submission paths inside sys.path (which is a list that allow duplication). This is to remove all possible policy paths inside sys.path.
There was a problem hiding this comment.
OK, that makes more sense please add a code comment about that.
zoo/policies/competition_agent.py
Outdated
| while self._sub_env_path in sys.path: | ||
| sys.path.remove(self._sub_env_path) | ||
| while self._policy_dir in sys.path: | ||
| sys.path.remove(self._policy_dir) | ||
| for key, module in list(sys.modules.items()): | ||
| if "__file__" in dir(module): | ||
| module_path = module.__file__ | ||
| if module_path and ( | ||
| self._policy_dir in module_path or self._sub_env_path in module_path | ||
| ): | ||
| sys.modules.pop(key) | ||
| if remove_all_env: | ||
| shutil.rmtree(self._comp_env_path, ignore_errors=True) |
There was a problem hiding this comment.
This cleanup seems to be related to the requirements for all agents of this type rather than the agent instance-specific resources. Maybe this can be registered as an atexit callback in the entrypoint?
There was a problem hiding this comment.
That sound reasonable, will do.
There was a problem hiding this comment.
After trying to turn it into a callback function, I suggest to keep this as before. Removing environment using callback function become slower and the program may crash frequently.
competition_agent integration with zoo.
run:
scl run --envision competition_agent_demo.py scenarios/sumo/loopto see competition integration with loop scenarios. To see other scenarios, replacescenarios/sumo/loopwith other scenarios path.