Skip to content

Fix Telekom HANFUN Devices#83

Merged
hthiery merged 5 commits into
hthiery:masterfrom
parliament119:fix/hanfun_lightbulbs_and_switches
Mar 3, 2023
Merged

Fix Telekom HANFUN Devices#83
hthiery merged 5 commits into
hthiery:masterfrom
parliament119:fix/hanfun_lightbulbs_and_switches

Conversation

@parliament119
Copy link
Copy Markdown
Contributor

To correctly detect Telekom HANFUN Lightbulbs which only support warm-white colors the provided functionbitmask needs to be checked for Bit 2: Licht/Lampe (from the http api).

For Telekom HANFUN plugs the Bit 15: an-/ausschaltbares Gerät/Steckdose/Lampe/Aktor needs to be checked.
Bit 9: Schaltsteckdose seems to be only valid for AVM-proprietary devices.

@MattBavaria
Copy link
Copy Markdown

Hello @hthiery,

I‘d like you to review that pull request.
I tried with Magenta switching plugs and it works for me.
Regards,
MattBavaria

@hthiery
Copy link
Copy Markdown
Owner

hthiery commented Mar 3, 2023

@parliament119 could you please check and fix the failing pipelines. In addition some unittest and adding your devices you tested your change on to the tested devices section in the README would be great.

Thanks

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2023

Coverage Status

Coverage: 92.411% (-0.4%) from 92.794% when pulling fcad791 on parliament119:fix/hanfun_lightbulbs_and_switches into e1ff696 on hthiery:master.

@hthiery
Copy link
Copy Markdown
Owner

hthiery commented Mar 3, 2023

@parliament119 could you please meld the fix commits (fix flake and fix response) to the corresponding commit?

thanks

@MattBavaria
Copy link
Copy Markdown

Hello,

if you like, you can add following devices as “tested” as well.

  • Magenta SmartHome Zwischenstecker innen
  • Magenta Smarthome Tür-/Fensterkontakt magnetisch

I tested them both with the patch I provided as well as with that branch.
Regards,
MattBavaria

@parliament119 parliament119 force-pushed the fix/hanfun_lightbulbs_and_switches branch from 0099a11 to fcad791 Compare March 3, 2023 22:11
@hthiery hthiery merged commit 128448d into hthiery:master Mar 3, 2023
@hthiery
Copy link
Copy Markdown
Owner

hthiery commented Mar 3, 2023

Thanks!

@hthiery
Copy link
Copy Markdown
Owner

hthiery commented Mar 3, 2023

@MattBavaria @parliament119 just tagged to 0.6.8 and published on pypi

@parliament119
Copy link
Copy Markdown
Contributor Author

Great! Thank you!

@MattBavaria
Copy link
Copy Markdown

@hthiery
Thank very much, looking forward to new integration in home assistant docker.

Regards,
MattBavaria

@parliament119
Copy link
Copy Markdown
Contributor Author

I opened up a Pull Request to fix the Home Assistant Integration.

@mib1185 mib1185 mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants