Skip to content

Bump pyfritzhome to 0.6.8 and add support for Non-Color-Bulbs#89141

Merged
mib1185 merged 2 commits into
home-assistant:devfrom
parliament119:fix_for_new_pyfritzhome
Mar 8, 2023
Merged

Bump pyfritzhome to 0.6.8 and add support for Non-Color-Bulbs#89141
mib1185 merged 2 commits into
home-assistant:devfrom
parliament119:fix_for_new_pyfritzhome

Conversation

@parliament119
Copy link
Copy Markdown
Contributor

@parliament119 parliament119 commented Mar 4, 2023

Breaking change

Proposed change

Bump pyfritzhome to new version 0.6.8 and enable the displaying of Non-Color-Bulbs which were not supported until now

diff: hthiery/python-fritzhome@0.6.7...0.6.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 4, 2023

Hi @parliament119

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 4, 2023

Hey there @mib1185, @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 added the dependency-bump Pull requests that update a dependency file label Mar 4, 2023
@mib1185
Copy link
Copy Markdown
Member

mib1185 commented Mar 4, 2023

Hi @parliament119

many thanks for this 👍
Please also add tests for this new feature, thx.

Comment thread homeassistant/components/fritzbox/light.py Outdated
@MartinHjelmare MartinHjelmare changed the title Bump pyfritzhome to 0.6.8 and add support for Non-Color-Bulbs in frit… Bump pyfritzhome to 0.6.8 and add support for Non-Color-Bulbs Mar 4, 2023
Comment thread tests/components/fritzbox/__init__.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not needed to have a separate light mock, just override the affected properties during the test

Comment thread tests/components/fritzbox/test_light.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft March 4, 2023 12:29
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mib1185
Copy link
Copy Markdown
Member

mib1185 commented Mar 4, 2023

Hi @parliament119
I've left some comments and would like to ask you to also update the list of tested devices in the docs.

@parliament119
Copy link
Copy Markdown
Contributor Author

Hey @mib1185!
Thanks for your feedback. I updated the test to check for the supported-color-modes and opened up a Pull Request for adding the tested device.

@flabbamann
Copy link
Copy Markdown
Contributor

flabbamann commented Mar 8, 2023

Hey @parliament119

Hey @mib1185! Thanks for your feedback. I updated the test to check for the supported-color-modes and opened up a Pull Request for adding the tested device.

Thank you @parliament119!
Adding the link to the documentation PR in this PR's description in Additional Information should fix the docs-missing issue.

Copy link
Copy Markdown
Member

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @parliament119 many thanks for this 👍

Copy link
Copy Markdown
Contributor

@flabbamann flabbamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm colored bulbs do still work 😉
Thank you!

@mib1185 mib1185 merged commit 7d97653 into home-assistant:dev Mar 8, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency-bump Pull requests that update a dependency file integration: fritzbox new-feature Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants