Skip to content

Return native voltage value#64

Merged
hthiery merged 1 commit into
hthiery:masterfrom
mib1185:equalize-powermeter-values
Aug 4, 2022
Merged

Return native voltage value#64
hthiery merged 1 commit into
hthiery:masterfrom
mib1185:equalize-powermeter-values

Conversation

@mib1185
Copy link
Copy Markdown
Collaborator

@mib1185 mib1185 commented Jun 8, 2022

This removes the division by 1000 on voltage value, since all other powermeter values are also returned "native"

@flabbamann
Copy link
Copy Markdown
Contributor

Wouldn't it be better to divide power too so we return proper values and can remove the divisor in Home Assistant? I think this is what users would expect from pyfritzhome.

@mib1185
Copy link
Copy Markdown
Collaborator Author

mib1185 commented Jun 8, 2022

TBH I would always prefer, that the native values are returned, so the user of this library can decide if he want's to calculate with mV and mW or V and W 🤔

@flabbamann
Copy link
Copy Markdown
Contributor

I guess its personal preference if you prefer to have mV and mW or V and W 😃
@hthiery your thoughts on this? The way it is now I'd say it is definitely a bug 😉.

@hthiery
Copy link
Copy Markdown
Owner

hthiery commented Aug 4, 2022

Sorry for the long delay . I will merge as is. Thank you.

@hthiery hthiery merged commit 36e87cb into hthiery:master Aug 4, 2022
@mib1185 mib1185 deleted the equalize-powermeter-values branch August 6, 2022 09:18
@AlexKay88 AlexKay88 mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fritzbox: Entities _electric_current and _voltage wrong multiplier/divisor 0,230V instead 230V

3 participants