Skip to content

Fix voltage and current values for Fritz!DECT smart plugs#73608

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
mib1185:fritzbox/fix-voltage-and-current-sensor-values
Jun 17, 2022
Merged

Fix voltage and current values for Fritz!DECT smart plugs#73608
MartinHjelmare merged 1 commit into
home-assistant:devfrom
mib1185:fritzbox/fix-voltage-and-current-sensor-values

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Jun 16, 2022

Proposed change

This is a workaround until hthiery/python-fritzhome/pull/64 gets merged and pyfritzhome gets bumped accordingly.
Tests were added to safe guard when dependency is updated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@mib1185 mib1185 added this to the 2022.6.7 milestone Jun 16, 2022
Comment thread homeassistant/components/fritzbox/sensor.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit e304784 into home-assistant:dev Jun 17, 2022
@mib1185 mib1185 deleted the fritzbox/fix-voltage-and-current-sensor-values branch June 17, 2022 08:27
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fritzbox: Entities _electric_current and _voltage wrong multiplier/divisor 0,230V instead 230V

5 participants