Skip to content

Bump pyfritzhome to 0.6.7#78324

Merged
frenck merged 4 commits into
home-assistant:devfrom
mib1185:fritzbox/bump-pyfritzhome-to-0.6.7
Sep 15, 2022
Merged

Bump pyfritzhome to 0.6.7#78324
frenck merged 4 commits into
home-assistant:devfrom
mib1185:fritzbox/bump-pyfritzhome-to-0.6.7

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Sep 12, 2022

Proposed change

This will bump pyfritzhome from 0.6.5 to 0.6.7.
Further the workaround from #73608 will be reverted, since hthiery/python-fritzhome/pull/64 is shipped with 0.6.7 and measurement values will be rounded to avoid unreasonable state changes.

Diff: hthiery/python-fritzhome@0.6.5...0.6.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade has-tests integration: fritzbox small-pr PRs with less than 30 lines. labels Sep 12, 2022
@probot-home-assistant
Copy link
Copy Markdown

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/fritzbox/sensor.py
Copy link
Copy Markdown
Contributor

@flabbamann flabbamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 👍

Comment thread homeassistant/components/fritzbox/sensor.py Outdated
@mib1185 mib1185 requested a review from frenck September 13, 2022 11:39
@mib1185 mib1185 force-pushed the fritzbox/bump-pyfritzhome-to-0.6.7 branch from 4351dd8 to d0e19b4 Compare September 13, 2022 11:39
@mib1185
Copy link
Copy Markdown
Member Author

mib1185 commented Sep 13, 2022

rebased to hopefully avoid unrelated coverage issues 🤞

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

@frenck frenck merged commit 6f02f7c into home-assistant:dev Sep 15, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2022
@mib1185 mib1185 deleted the fritzbox/bump-pyfritzhome-to-0.6.7 branch September 17, 2022 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade has-tests integration: fritzbox small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants