Skip to content

Adds config validation to configuration plugin#9886

Merged
balloob merged 1 commit into
currentfrom
frenck-2019-0111
Jul 18, 2019
Merged

Adds config validation to configuration plugin#9886
balloob merged 1 commit into
currentfrom
frenck-2019-0111

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jul 17, 2019

Description:

This updates our Jekyll configuration plugin (responsible for rendering the configuration blocks).

Markdown in config values

It adds support for rendering config values as Markdown by parsing the values. This broken when we switched Markdown parser. The output wasn't actually Markdown, but mixed HTML/Markdown. By Markdown parsing values separately, this becomes just HTML as output.

Configuration validation

Secondly, it adds a bunch of check to the configuration, basically adding config validation.
If the configuration block contains invalid values/syntax/types/ect the site build will fail with a proper error message.

All current configuration blocks are corrected using this check: #9884 and #9874.

⚠️ This PR cannot be merged until we have done a release. Merging this in right now, will work, but will cause issues with merging in the rc branch (aka release).

📆 The plan:

  • Wait for release, manual check and correct everything again, correct if needed.
  • Merge current -> next
  • Run on next manually and correct if needed.
  • Merge this PR on current
  • Merge current -> next

Screenshots of build errors

image

image

image

image

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@frenck frenck added enhancement current This PR goes into the current branch labels Jul 17, 2019
@frenck frenck self-assigned this Jul 17, 2019
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jul 17, 2019
@frenck frenck force-pushed the frenck-2019-0111 branch from 56cacd4 to d6ad12e Compare July 18, 2019 17:12
@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jul 18, 2019

Rebased.

@frenck frenck marked this pull request as ready for review July 18, 2019 17:23
@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jul 18, 2019
@balloob balloob merged commit b1e7286 into current Jul 18, 2019
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2019-0111 branch July 18, 2019 21:55
KJonline pushed a commit to Rendili/home-assistant.github.io that referenced this pull request Jul 19, 2019
…nt.io into next

* 'next' of https://github.com/home-assistant/home-assistant.io: (66 commits)
  Update totalconnect.markdown (home-assistant#9589)
  add HmIP-FCI1, HmIP-BBL, HmIP-FBL to Homematic IP Cloud (home-assistant#9873)
  Update neato configuration to include vendor support (home-assistant#9882)
  Add documentation for new Rainforest Eagle-200 platform (home-assistant#9761)
  Add MQTT climate precision (home-assistant#9896)
  Adds config validation to configuration plugin (home-assistant#9886)
  Fix example (home-assistant#9899)
  Clarify modes is limited to a specific set. (home-assistant#9897)
  Mode `on` is now `heat` (home-assistant#9893)
  Update climate.markdown (home-assistant#9894)
  Collection of configuration block fixes (home-assistant#9892)
  Collection of configuration block fixes (home-assistant#9884)
  Add info about concurrent use of data and data_template (home-assistant#9889)
  Add info about concurrent use of data and data_template (home-assistant#9890)
  Updating template example (home-assistant#9891)
  Mention podcast
  Mention 25k stars
  Update solaredge_local.markdown (home-assistant#9878)
  Add Py35 msg
  Fix code blocks in breaking changes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch ready-for-review This PR needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants