Skip to content

Update totalconnect.markdown#9589

Merged
frenck merged 5 commits intohome-assistant:nextfrom
austinmroczek:patch-8
Jul 18, 2019
Merged

Update totalconnect.markdown#9589
frenck merged 5 commits intohome-assistant:nextfrom
austinmroczek:patch-8

Conversation

@austinmroczek
Copy link
Copy Markdown
Contributor

@austinmroczek austinmroczek commented Jun 8, 2019 •
edited by gitpod-io Bot
Loading

Description:
Update docs to show new configuration entry requirement.

Also adds suggestion to use a separate, non administrative account Total Connect account with HA.

Pull request in home-assistant (if applicable): home-assistant/core#24427

Checklist:

  • [next] Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@austinmroczek austinmroczek mentioned this pull request Jun 8, 2019
Merged
6 tasks
@klaasnicolaas klaasnicolaas added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jun 10, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Jun 10, 2019

Please rebase to the next branch

@frenck frenck added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Jun 18, 2019
frenck
frenck requested changes Jun 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austinmroczek this PR targets the wrong branch. It currently targets current, but it should target the next branch. Please change the target and rebase if needed.

@austinmroczek
Copy link
Copy Markdown
Contributor Author

austinmroczek commented Jun 19, 2019

Sorry I’ve been out of town. Hope to get to it this weekend

@austinmroczek austinmroczek changed the base branch from current to next June 29, 2019 16:49
@austinmroczek
Copy link
Copy Markdown
Contributor Author

austinmroczek commented Jun 29, 2019

Changed to Next. Thanks

frenck
frenck requested changes Jun 30, 2019
View reviewed changes
Comment thread source/_components/totalconnect.markdown Outdated
Comment thread source/_components/totalconnect.markdown Outdated
Comment thread source/_components/totalconnect.markdown Outdated
@klaasnicolaas klaasnicolaas removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jun 30, 2019
austinmroczek and others added 3 commits June 30, 2019 16:08
@austinmroczek
Copy link
Copy Markdown
Contributor Author

austinmroczek commented Jun 30, 2019

Made updates per recommendations. Thanks

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jul 1, 2019
frenck
frenck previously approved these changes Jul 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments @austinmroczek! 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.

@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Jul 9, 2019

⚠️ We have I merge conflict

@klaasnicolaas klaasnicolaas added the in-progress This PR/Issue is currently being worked on label Jul 9, 2019
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Jul 14, 2019
@frenck frenck added next This PR goes into the next branch and removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Jul 18, 2019
@frenck frenck merged commit 08d0a52 into home-assistant:next Jul 18, 2019
KJonline pushed a commit to Rendili/home-assistant.github.io that referenced this pull request Jul 19, 2019
Merge branch 'next' of https://github.com/home-assistant/home-assista…
a4760d0 
…nt.io into next

* 'next' of https://github.com/home-assistant/home-assistant.io: (66 commits)
  Update totalconnect.markdown (home-assistant#9589)
  add HmIP-FCI1, HmIP-BBL, HmIP-FBL to Homematic IP Cloud (home-assistant#9873)
  Update neato configuration to include vendor support (home-assistant#9882)
  Add documentation for new Rainforest Eagle-200 platform (home-assistant#9761)
  Add MQTT climate precision (home-assistant#9896)
  Adds config validation to configuration plugin (home-assistant#9886)
  Fix example (home-assistant#9899)
  Clarify modes is limited to a specific set. (home-assistant#9897)
  Mode `on` is now `heat` (home-assistant#9893)
  Update climate.markdown (home-assistant#9894)
  Collection of configuration block fixes (home-assistant#9892)
  Collection of configuration block fixes (home-assistant#9884)
  Add info about concurrent use of data and data_template (home-assistant#9889)
  Add info about concurrent use of data and data_template (home-assistant#9890)
  Updating template example (home-assistant#9891)
  Mention podcast
  Mention 25k stars
  Update solaredge_local.markdown (home-assistant#9878)
  Add Py35 msg
  Fix code blocks in breaking changes
  ...
@austinmroczek austinmroczek deleted the patch-8 branch May 29, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@austinmroczek @klaasnicolaas @frenck @MartinHjelmare