Update solaredge_local.markdown#9878
Conversation
Remove sensors: section head. This is an incorrect section header. Adding the platform as a list item so new users can copy and paste into existing sensor sections.
|
I'm thinking of not merging this since it will create an inconsistency in our documentation... |
|
as a counter-argument... depending on your configuration method, even your changed version is not copied & pasteable. |
|
Thought about this a bit more, I appreciate the way you think about the usability, however, consistency is an important factor as well. Switching style on a single location, while keeping all the rest as is, is probably worse at this point. Hence I'm closing this PR. |
|
Is it better that users copy an absolut wrong example that doesn't work? |
That depends on the situation, the change provided has the same effect for others as well. |
|
Well at least we should remove the typo |
|
Aah, I see, the issue now! However, this PR also removed the |
|
Yeah, I only a removed the 'sensor:' bit because some people don't understand the whole 'can't have more than 1 sensor section' restriction. |
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
👍 Tweaked it a bit and this should be good to go!
Sorry for the confusion there! 🙏
|
@Petro31 I get that, nevertheless, that is not something we should do on a single location. If we consider doing that, it should be decided more widely and changed widely. |
|
@frenck yeah not a problem. I'm good with whatever changes we make. |
…nt.io into next * 'next' of https://github.com/home-assistant/home-assistant.io: (66 commits) Update totalconnect.markdown (home-assistant#9589) add HmIP-FCI1, HmIP-BBL, HmIP-FBL to Homematic IP Cloud (home-assistant#9873) Update neato configuration to include vendor support (home-assistant#9882) Add documentation for new Rainforest Eagle-200 platform (home-assistant#9761) Add MQTT climate precision (home-assistant#9896) Adds config validation to configuration plugin (home-assistant#9886) Fix example (home-assistant#9899) Clarify modes is limited to a specific set. (home-assistant#9897) Mode `on` is now `heat` (home-assistant#9893) Update climate.markdown (home-assistant#9894) Collection of configuration block fixes (home-assistant#9892) Collection of configuration block fixes (home-assistant#9884) Add info about concurrent use of data and data_template (home-assistant#9889) Add info about concurrent use of data and data_template (home-assistant#9890) Updating template example (home-assistant#9891) Mention podcast Mention 25k stars Update solaredge_local.markdown (home-assistant#9878) Add Py35 msg Fix code blocks in breaking changes ...
4 participants
Remove sensors: section head. This is an incorrect section header. Adding the platform as a list item so new users can copy and paste into existing sensor sections.
Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.