Adding enigma2 media player#8776
Merged
Merged
Conversation
ghost
added
the
Contributor
Author
|
apologies @klaasnicolaas I had to clean up my fork so ended up opening this fresh PR. |
8 tasks
klaasnicolaas
added
new-integration
klaasnicolaas
requested changes
Feb 28, 2019
Contributor
Author
|
@klaasnicolaas all comments addressed (I think). |
klaasnicolaas
previously approved these changes
Mar 2, 2019
Member
klaasnicolaas
left a comment
klaasnicolaas
left a comment
There was a problem hiding this comment.
✅ approved
ha_release must be updated before merging
klaasnicolaas
added
awaits-parent
rytilahti
previously approved these changes
Mar 8, 2019
Member
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Looks good to me, added a note about a couple of potential improvements!
rytilahti
approved these changes
Mar 8, 2019
Member
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Can be merged when the parent gets merged, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adding enigma2 docs. (this is based on comments from a stale review here: #5984 ).
Pull request in home-assistant (if applicable): home-assistant/core#21271
Checklist:
current. New documentation for platforms/components and features should go tonext.