Adding enigma2 media player by fbradyirl · Pull Request #21271 · home-assistant/core

fbradyirl · 2019-02-21T16:51:23Z

Description:

This PR adds support for Enigma2 based set top box receivers. Examples include devices from Vu (Duo, Duo2, Uno, etc) and lots of manufacturers who support the open sourced images based on Enigma2, such as OpenVix and Black Hole.

At present, the platform supports:

Power standby/wake toggle (on/off)
Select next/prev channel
Volume set
Mute/unmute
Query current program info such as:
- TV station active,
- Programme Name & Description
- Picon (channel icon) for the station
Auto-discover of enigma2 boxes (via netdisco - Pull request in netdisco:** Add support for discovering enigma2 based devices home-assistant-libs/netdisco#241 )

How does it work?

)

note: Component should be worded 'Platform' in the diagram

This PR contains a media_player platform named enigma2 for Home Assistant, which allows basic control of the unit and the TV via my 3rd party pip module, called openwebifpy.

More details and example automations can be found here.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8776

Discovery

Pull request in netdisco: home-assistant-libs/netdisco#241

Example entry for `configuration.yaml` (if applicable):

# Example configuration.yaml entry
media_player:
  - platform: enigma2
    host: 192.168.1.12
    name: Vu Duo2

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

fbradyirl · 2019-02-25T13:42:32Z

cc @cinzas @KavajNaruj (I know you guys previously worked on enigma2 PRs).

cinzas · 2019-02-28T14:21:36Z

Hi, I had my PR closed, maybe I will reopen it since I've now changed enigma2 to a platform that implements media_player and notify.

Let me know if you PR gets accepted.

With my component you have a little more features

Nevertheless, great work :)

fbradyirl · 2019-03-01T14:22:50Z

cc @mihalski for review (if you have time!)

fbradyirl · 2019-03-02T20:47:44Z

@balloob I think all your comments should be addressed now. Let me know if there's anything else you need. Thanks.

- support better recording playback integration

adrianmihalko · 2019-03-05T15:31:51Z

Wow, thank you. I hope it will be merged soon.

rytilahti

After reading your comment wrt. adding API to the upstream lib, I added a couple of things that could be done nicer inside the lib to provide a cleaner interface for homeassistant.

fbradyirl · 2019-03-06T22:56:13Z

Thank you @rytilahti for your review. I do agree with all your comments. Most of those things should be encapsulated inside the module and I’ll do that tomorrow.

rytilahti

Thanks, looks good, I added a couple of nitpicks but I think this is ready to be merged!

- rename prefer_picon to use_channel_icon

rytilahti · 2019-03-08T12:22:36Z

Please fix the travis build, I'll do a quick review on the docs and I think this can be then merged! 🎉

also fix travis also move setup out of init

fbradyirl · 2019-03-08T12:32:08Z

Please fix the travis build, I'll do a quick review on the docs and I think this can be then merged! 🎉

Thank you @rytilahti ! I was actually just doing some work there to move the setup of the device outside of the __init__, so I hope you like that also.

I did some testing on discovery and non-discovery and it all works well.

Thanks again!

fbradyirl · 2019-03-08T14:34:27Z

Note: for auto-discovery to work for this platform, we will need a bump of the Netdisco library since this PR got merged.

home-assistant-libs/netdisco#241

cc @balloob

MartinHjelmare · 2019-03-08T16:28:34Z

    SERVICE_HASSIO: ('hassio', None),
    SERVICE_AXIS: ('axis', None),
    SERVICE_APPLE_TV: ('apple_tv', None),
+    SERVICE_ENIGMA2: ('enigma2', None),


Inserting media_player platform as first item in the tuple would load that platform directly instead of loading the component and firing the event.

MartinHjelmare · 2019-03-08T16:31:36Z

+        """List of available input sources."""
+        return self.e2_box.source_list
+
+    @asyncio.coroutine


Use async def instead of coroutine decorator.

MartinHjelmare · 2019-03-08T16:32:06Z

+    @asyncio.coroutine
+    def async_select_source(self, source):
+        """Select input source."""
+        self.e2_box.select_source(self.e2_box.sources[source])


Is this async safe?

MartinHjelmare · 2019-03-08T16:35:23Z

+            attributes[ATTR_MEDIA_DESCRIPTION] = \
+                self.e2_box.status_info['currservice_fulldescription']
+            attributes[ATTR_MEDIA_START_TIME] = \
+                self.e2_box.status_info['currservice_begin']


Are these times absolute utc?

homeassistant added new-platform platform: media_player.enigma2 cla-signed labels Feb 21, 2019

ghost added the in progress label Feb 21, 2019

houndci-bot reviewed Feb 21, 2019

View reviewed changes

Comment thread homeassistant/components/media_player/enigma2.py Outdated

Comment thread homeassistant/components/media_player/enigma2.py Outdated

fbradyirl mentioned this pull request Feb 21, 2019

Adding enigma2 docs home-assistant/home-assistant.io#8669

Closed

2 tasks

fbradyirl commented Feb 21, 2019

View reviewed changes

Comment thread homeassistant/components/media_player/enigma2.py Outdated

fbradyirl commented Feb 21, 2019

View reviewed changes

Comment thread homeassistant/components/media_player/enigma2.py Outdated

houndci-bot reviewed Feb 21, 2019

View reviewed changes

Comment thread homeassistant/components/media_player/enigma2.py Outdated

Comment thread homeassistant/components/media_player/enigma2.py Outdated

fbradyirl commented Feb 21, 2019

View reviewed changes

Comment thread homeassistant/components/media_player/enigma2.py Outdated

fbradyirl requested a review from a team as a code owner February 22, 2019 12:13