Skip to content

Adding enigma2 docs#5984

Closed
fbradyirl wants to merge 5 commits into
home-assistant:nextfrom
fbradyirl:next
Closed

Adding enigma2 docs#5984
fbradyirl wants to merge 5 commits into
home-assistant:nextfrom
fbradyirl:next

Conversation

@fbradyirl
Copy link
Copy Markdown
Contributor

@fbradyirl fbradyirl commented Aug 9, 2018

Description:
Adding enigma2 docs

Pull request in home-assistant (if applicable): home-assistant/core#15799

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 9, 2018
@fbradyirl fbradyirl mentioned this pull request Aug 9, 2018
Closed
8 tasks
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Aug 9, 2018
@ghost ghost assigned frenck Aug 9, 2018
frenck
frenck requested changes Aug 9, 2018
View reviewed changes
Comment thread source/_components/media_player.enigma2.markdown Outdated
media_player:
- platform: enigma2
host: 192.168.1.12
name: Vu Duo2
Copy link
Copy Markdown
Member

@frenck frenck Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Aug 9, 2018
@frenck frenck assigned fbradyirl and unassigned frenck Aug 9, 2018
fbradyirl
fbradyirl commented Aug 9, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@fbradyirl fbradyirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck agree with your comments. I’ve removed the optional config from sample.

@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Aug 10, 2018
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Oct 4, 2018
tjorim
tjorim suggested changes Oct 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tjorim tjorim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbradyirl, only one question for you sir.

⚠️ The ha_release will need an update before merging this one in.

Comment thread source/_components/media_player.enigma2.markdown
host: 192.168.1.12
```

{% configuration %}
Copy link
Copy Markdown
Contributor

@tjorim tjorim Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the code the network port can be configured as well.
If that is correct, add it to this section and mention the default (80).

frenck
frenck requested changes Oct 18, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, @tjorim!
@fbradyirl, could you add the missing option? 👍

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed awaits-parent Awaits the merge of an parent PR labels Oct 18, 2018
@cgarwood cgarwood added the stale The PR had no activity for quite some time, and is marked as Stale label Nov 3, 2018
@cgarwood
Copy link
Copy Markdown
Member

cgarwood commented Nov 3, 2018

Parent PR went stale and was closed, closing this one.

@cgarwood cgarwood closed this Nov 3, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Nov 3, 2018
This was referenced Feb 21, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck requested changes

+1 more reviewer

@tjorim tjorim tjorim requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fbradyirl fbradyirl

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch stale The PR had no activity for quite some time, and is marked as Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fbradyirl @cgarwood @frenck @tjorim