Skip to content

Add SmartThings Fan platform#8376

Closed
andrewsayre wants to merge 3 commits intohome-assistant:nextfrom
andrewsayre:feature-smartthings-fan
Closed

Add SmartThings Fan platform#8376
andrewsayre wants to merge 3 commits intohome-assistant:nextfrom
andrewsayre:feature-smartthings-fan

Conversation

@andrewsayre
Copy link
Copy Markdown
Member

@andrewsayre andrewsayre commented Feb 2, 2019

Description:
Adds documentation for the SmartThings Fan platform.

Pull request in home-assistant (if applicable): home-assistant/core#20681

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Feb 2, 2019
@klaasnicolaas klaasnicolaas added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed awaits-parent Awaits the merge of an parent PR next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Feb 2, 2019
footer: true
logo: samsung_smartthings.png
ha_category: Fan
ha_release: ""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.87

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the parent PR still be included in the 0.87 release?

Copy link
Copy Markdown
Contributor

@arsaboo arsaboo Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the hope (and looks like it should be) and we can update it if it doesn't :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see the light prioritized as that will be more valuable to the users and that PR fixes/standardizes a few things this one is assuming. Getting both in would be good too though. :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it to 0.87, assuming it will go in.

@andrewsayre andrewsayre mentioned this pull request Feb 2, 2019
2 tasks
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #8389

@andrewsayre andrewsayre closed this Feb 2, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Feb 2, 2019
@andrewsayre andrewsayre deleted the feature-smartthings-fan branch February 2, 2019 22:44
@c0ffeeca7 c0ffeeca7 removed the awaits-parent Awaits the merge of an parent PR label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants