Add SmartThings Fan platform#8376
Closed
andrewsayre wants to merge 3 commits intohome-assistant:nextfrom
andrewsayre:feature-smartthings-fan
Closed
Add SmartThings Fan platform#8376andrewsayre wants to merge 3 commits intohome-assistant:nextfrom andrewsayre:feature-smartthings-fan
andrewsayre wants to merge 3 commits intohome-assistant:nextfrom
andrewsayre:feature-smartthings-fan
Conversation
5 tasks
arsaboo
reviewed
Feb 2, 2019
| footer: true | ||
| logo: samsung_smartthings.png | ||
| ha_category: Fan | ||
| ha_release: "" |
Member
There was a problem hiding this comment.
Will the parent PR still be included in the 0.87 release?
Contributor
There was a problem hiding this comment.
That is the hope (and looks like it should be) and we can update it if it doesn't :)
Member
Author
There was a problem hiding this comment.
I'd prefer to see the light prioritized as that will be more valuable to the users and that PR fixes/standardizes a few things this one is assuming. Getting both in would be good too though. :)
Member
Author
There was a problem hiding this comment.
Updated it to 0.87, assuming it will go in.
2 tasks
fabaff
requested changes
Feb 2, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds documentation for the SmartThings Fan platform.
Pull request in home-assistant (if applicable): home-assistant/core#20681
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.