Fix SmartThings Switch Platform#8389
Closed
andrewsayre wants to merge 1 commit intohome-assistant:nextfrom
andrewsayre:fix_merge_redirect
Closed
Fix SmartThings Switch Platform#8389andrewsayre wants to merge 1 commit intohome-assistant:nextfrom andrewsayre:fix_merge_redirect
andrewsayre wants to merge 1 commit intohome-assistant:nextfrom
andrewsayre:fix_merge_redirect
Conversation
fabaff
requested changes
Feb 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Reverts the changes of #8357 so that the switch platform is consistent with the other platforms that have integration details (#8388, #8376, and #8365).
While switch doesn't have details today, it will in the future, once it supports other capabilities, like power meter. To keep the component page lean (instructions for setting up the integration), the SmartThings-device-to-platform mapping details are within each platform page.
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.