Add SmartThings Fan platform#20681
Merged
balloob merged 5 commits intohome-assistant:devfrom Feb 2, 2019
andrewsayre:feature-smartthings-fan
Merged
Add SmartThings Fan platform#20681balloob merged 5 commits intohome-assistant:devfrom andrewsayre:feature-smartthings-fan
balloob merged 5 commits intohome-assistant:devfrom
andrewsayre:feature-smartthings-fan
Conversation
ghost
added
the
2 tasks
balloob
reviewed
Feb 2, 2019
balloob
reviewed
Feb 2, 2019
MartinHjelmare
approved these changes
Feb 2, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Two possible clean ups.
MartinHjelmare
approved these changes
Feb 2, 2019
balloob
pushed a commit
that referenced
this pull request
Feb 2, 2019
* Add SmartThings fan * Removed unnecessary update method * Corrected usage of async_schedule_update_ha_state * Clean-up/optimization
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds the SmartThings Fanplatform that represents SmartThings devices that have fan-related capabilities. Highlights:
speed(other fan features are not currently exposed by SmartThings)Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8376
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: