Skip to content

Add query button entities to ISY994 devices and hub#25609

Merged
frenck merged 4 commits into
home-assistant:nextfrom
shbatm:patch-1
Jan 9, 2023
Merged

Add query button entities to ISY994 devices and hub#25609
frenck merged 4 commits into
home-assistant:nextfrom
shbatm:patch-1

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented Jan 6, 2023

Proposed change

Deprecate the isy994.system_query service in favor of Query button entities.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@shbatm shbatm requested a review from bdraco as a code owner January 6, 2023 19:54
@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 6, 2023
Comment thread source/_integrations/isy994.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jan 7, 2023
@frenck frenck added the parent-merged The parent PR has been merged already label Jan 7, 2023
@shbatm shbatm removed their assignment Jan 8, 2023
@shbatm shbatm requested review from frenck and removed request for bdraco January 8, 2023 19:28
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shbatm 👍

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shbatm A wild merge conflict appeared out of nowhere! 🙈
Could you take a look?

Thanks! 👍

../Frenck

@shbatm
Copy link
Copy Markdown
Contributor Author

shbatm commented Jan 9, 2023

My fault--removing several services over a few different PRs.

@shbatm shbatm removed their assignment Jan 9, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shbatm 👍

../Frenck

@frenck frenck merged commit e30139e into home-assistant:next Jan 9, 2023
@home-assistant home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Jan 9, 2023
@shbatm shbatm deleted the patch-1 branch January 10, 2023 00:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants