Add query button entities to ISY994 devices and hub#85337
Merged
Conversation
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This was referenced Jan 6, 2023
Contributor
Author
|
@bdraco Want a "BEEP" button too for Insteon, or just leave that in the "raw commands" service? |
Member
We could do a beep that is disabled by default in the entity registry |
Contributor
Author
|
OK. Will add after this is merged. |
bdraco
reviewed
Jan 6, 2023
bdraco
reviewed
Jan 7, 2023
shbatm
commented
Jan 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The
isy994.system_queryservice is being depreciated and will be removed in a future release,Querybutton entities are now available for each ISY/IoX device and the hub and those should be used instead.Proposed change
Add the
buttonplatform to ISY994 and create "Query" entities to query nodes on the ISY (similar to the "Ping" button in Z-Wave JS). An entity for the hub will also be created to allow for a system-wide query (recommended by UDI to be run once every day).These button entities will eliminate the need for the
isy994.system_queryintegration-specific service. I've set the warnings for the 2023.5.0 version assuming this makes it into 2023.2.0 + 3-month depreciation period.This also includes minor cleanup in the
helpers.pyfile to use thePlatformenum instead of importing names from the various platforms.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: