Skip to content

Add query button entities to ISY994 devices and hub#85337

Merged
bdraco merged 6 commits into
home-assistant:devfrom
shbatm:isy994_query_button
Jan 7, 2023
Merged

Add query button entities to ISY994 devices and hub#85337
bdraco merged 6 commits into
home-assistant:devfrom
shbatm:isy994_query_button

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented Jan 6, 2023

Breaking change

The isy994.system_query service is being depreciated and will be removed in a future release, Query button entities are now available for each ISY/IoX device and the hub and those should be used instead.

Proposed change

Add the button platform to ISY994 and create "Query" entities to query nodes on the ISY (similar to the "Ping" button in Z-Wave JS). An entity for the hub will also be created to allow for a system-wide query (recommended by UDI to be run once every day).

These button entities will eliminate the need for the isy994.system_query integration-specific service. I've set the warnings for the 2023.5.0 version assuming this makes it into 2023.2.0 + 3-month depreciation period.

This also includes minor cleanup in the helpers.py file to use the Platform enum instead of importing names from the various platforms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 6, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (isy994) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of isy994 can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign isy994 Removes the current integration label and assignees on the issue, add the integration domain after the command.

@shbatm
Copy link
Copy Markdown
Contributor Author

shbatm commented Jan 6, 2023

@bdraco Want a "BEEP" button too for Insteon, or just leave that in the "raw commands" service?

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 6, 2023

@bdraco Want a "BEEP" button too for Insteon, or just leave that in the "raw commands" service?

We could do a beep that is disabled by default in the entity registry

@shbatm
Copy link
Copy Markdown
Contributor Author

shbatm commented Jan 6, 2023

OK. Will add after this is merged.

Comment thread homeassistant/components/isy994/services.py Outdated
Comment thread homeassistant/components/isy994/services.py Outdated
Comment thread homeassistant/components/isy994/services.py
@bdraco bdraco added the deprecation Indicates a breaking change to happen in the future label Jan 7, 2023
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@bdraco bdraco merged commit cf3ca81 into home-assistant:dev Jan 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants