Skip to content

Add documentation for SmartTub services#16721

Merged
frenck merged 2 commits into
home-assistant:nextfrom
mdz:mdz/smarttub-services
May 25, 2021
Merged

Add documentation for SmartTub services#16721
frenck merged 2 commits into
home-assistant:nextfrom
mdz:mdz/smarttub-services

Conversation

@mdz
Copy link
Copy Markdown
Contributor

@mdz mdz commented Feb 24, 2021

Proposed change

Two new services for updating the filtration cycle settings.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 24, 2021
@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Feb 24, 2021
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Feb 24, 2021
@frenck frenck added the parent-merged The parent PR has been merged already label May 23, 2021
@bdraco bdraco removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 24, 2021
Comment thread source/_integrations/smarttub.markdown Outdated
Comment thread source/_integrations/smarttub.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mdz 👍

@frenck frenck merged commit e974f3f into home-assistant:next May 25, 2021
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label May 25, 2021
@mdz
Copy link
Copy Markdown
Contributor Author

mdz commented May 25, 2021

Thanks! I'm curious, why should entity_id be documented as optional in this case?

@mdz mdz deleted the mdz/smarttub-services branch May 25, 2021 15:26
@frenck
Copy link
Copy Markdown
Member

frenck commented May 25, 2021

Because they are entity services, which can be targeted using an area or device as well

@mdz
Copy link
Copy Markdown
Contributor Author

mdz commented May 25, 2021 via email

@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants