Add service to snooze SmartTub reminders#51012
Merged
Merged
Conversation
Contributor
Author
|
I'll add documentation for this once home-assistant/home-assistant.io#16721 has been merged |
Member
|
The docs PR has been merged @mdz 👍 |
8 tasks
frenck
requested changes
May 25, 2021
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Really tiny comment. Otherwise, it looks good 👍
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Contributor
Author
|
Committed suggestions, thank you |
frenck
approved these changes
May 25, 2021
Member
|
Thanks, @mdz 👍 |
| """Return the device class for this entity.""" | ||
| return DEVICE_CLASS_PROBLEM | ||
|
|
||
| async def async_snooze(self, **kwargs): |
Member
There was a problem hiding this comment.
We don't need to accept kwargs here. We can just name the parameter the same as the service data attribute, ie days.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a new service, to allow a reminder to be snoozed (suppressed for a period of time)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: