Add services to SmartTub for changing filtration settings

[mdz]

Proposed change

Adds smarttub.set_primary_filtration and smarttub.set_secondary_filtration services.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add documentation for SmartTub services home-assistant.io#16721
• Docs preview: https://deploy-preview-16721--home-assistant-docs.netlify.app/integrations/smarttub/

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[bdraco]

@mdz. Were you able to retest?

[mdz]

@bdraco yes, the service calls work fine, but I haven't been able to get the services.yaml changes working properly. Even if I just put an empty target: stanza in there, I don't get an entity selection drop-down in the front end

[bdraco]

Try rebasing to the latest dev, there is a new frontend package.

[mdz]

I'm not sure what was wrong, but with 2021.3.0b3 + this branch as a custom integration it seems to be working now.

I'm able to filter the target entities by platform and domain, which is better than nothing, but it would be best to have the service only target the relevant entity (SmartTubPrimaryFiltrationCycle for set_primary_filtration and SmartTubSecondaryFiltrationCycle for set_secondary_filtration). I tried to get that to work, but couldn't, so I rolled it back in 02cb31f

[bdraco]

Looks like this has a conflict now.

[mdz]

Resolved

[mdz]

Only one is required. I didn't see a way to express that in the services.yaml

…

On Tue, Mar 16, 2021, 09:29 Franck Nijhof ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In homeassistant/components/smarttub/sensor.py <#46980 (comment)>: > + vol.Optional(ATTR_DURATION): vol.All(int, vol.Range(min=1, max=24)), + vol.Optional(ATTR_START_HOUR): vol.All(int, vol.Range(min=0, max=23)), According to the service.yaml file, both are required? According to this, at least one key? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46980 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKVL3VOXBWHQGH6NW6RFDTD6BPZANCNFSM4YDU6CCQ> .

[frenck]

That is correct, but maybe its better to not have them both required in that case? (at least for the services.yaml file, as the service schema still protects it from bad input).

[mdz]

OK, I'll make neither required then

…

On Tue, Mar 16, 2021 at 1:03 PM Franck Nijhof ***@***.***> wrote: That is correct, but maybe its better to not have them both required in that case? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46980 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKVL6CCW3Q3TGR45EJTSDTD62PZANCNFSM4YDU6CCQ> .

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[mdz]

@frenck mind taking another look?

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[mdz]

Still relevant

[bdraco]

Looks good 👍