Skip to content

added link to f.lux webpage #15051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IvxLars wants to merge 1 commit into from
Closed

added link to f.lux webpage #15051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/_integrations/flux.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ ha_quality_scale: internal
ha_domain: flux
---

The `flux` switch platform will change the temperature of your lights similar to the way flux works on your computer, using circadian rhythm. They will be bright during the day, and gradually fade to a red/orange at night. The `flux` switch restores its last state after startup.
The `flux` switch platform will change the temperature of your lights similar to the way flux works on your computer, using circadian rhythm.
They will be bright during the day, and gradually fade to a red/orange at night. See more on the [f.lux web page](https://justgetflux.com/).
Copy link
Copy Markdown
Member

@frenck frenck Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be confusing since this integration has absolutely nothing to do with the software offered on the linked page.

Copy link
Copy Markdown
Author

@IvxLars IvxLars Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intro states, " similar to the way flux works on your computer", so I figured I would add a link to help people read about what it actually does. The software is different, but the principle is described.

Copy link
Copy Markdown
Member

@frenck frenck Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, maybe we should describe the principle ourselves?

Copy link
Copy Markdown
Author

@IvxLars IvxLars Oct 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this version is a copy of a hue plugin, which is directly saying it is an implementation of f.lux, why not give credits to the original inventor of the f.lux software?

Copy link
Copy Markdown
Member

@frenck frenck Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not giving credit, this is sending people to another software package for context. Those are two different things, and the initial concern I raised. (So back at square 1)

Copy link
Copy Markdown
Author

@IvxLars IvxLars Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i was trying to help by expanding with a link to the original software and explanation which this plugin is inspired by, but you can just reject the PR, and I will find elsewhere to contribute.

Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that the key question is, why is there a flux integration without a connection with the flux software. Is it actually correct that it bears the name flux? Or would it be better to integrate this integration in terms of features with an emerging integration that has the same functions? Like #14877

Copy link
Copy Markdown
Member

@frenck frenck Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i was trying to help by expanding with a link to the original software and explanation which this plugin is inspired by, but you can just reject the PR, and I will find elsewhere to contribute.

It has nothing to do with that software. That is the whole point.

As you wish, closing.

The `flux` switch restores its last state after startup.

The integration will update your lights based on the time of day. It will only affect lights that are turned on and listed in the flux configuration.

Expand Down