Skip to content

added link to f.lux webpage#15051

Closed
IvxLars wants to merge 1 commit into
home-assistant:currentfrom
IvxLars:patch-1
Closed

added link to f.lux webpage#15051
IvxLars wants to merge 1 commit into
home-assistant:currentfrom
IvxLars:patch-1

Conversation

@IvxLars
Copy link
Copy Markdown

@IvxLars IvxLars commented Oct 8, 2020

To help people that does not know f.lux already

Proposed change

To help people that does not know f.lux already, a link to the webpage of f.lux has been added

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • [x ] Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: none

Checklist

  • [ x] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [ x] The documentation follows the Home Assistant documentation standards.

To help people that does not know f.lux already
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 8, 2020

The `flux` switch platform will change the temperature of your lights similar to the way flux works on your computer, using circadian rhythm. They will be bright during the day, and gradually fade to a red/orange at night. The `flux` switch restores its last state after startup.
The `flux` switch platform will change the temperature of your lights similar to the way flux works on your computer, using circadian rhythm.
They will be bright during the day, and gradually fade to a red/orange at night. See more on the [f.lux web page](https://justgetflux.com/).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be confusing since this integration has absolutely nothing to do with the software offered on the linked page.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intro states, " similar to the way flux works on your computer", so I figured I would add a link to help people read about what it actually does. The software is different, but the principle is described.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, maybe we should describe the principle ourselves?

Copy link
Copy Markdown
Author

@IvxLars IvxLars Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this version is a copy of a hue plugin, which is directly saying it is an implementation of f.lux, why not give credits to the original inventor of the f.lux software?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not giving credit, this is sending people to another software package for context. Those are two different things, and the initial concern I raised. (So back at square 1)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i was trying to help by expanding with a link to the original software and explanation which this plugin is inspired by, but you can just reject the PR, and I will find elsewhere to contribute.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that the key question is, why is there a flux integration without a connection with the flux software. Is it actually correct that it bears the name flux? Or would it be better to integrate this integration in terms of features with an emerging integration that has the same functions? Like #14877

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i was trying to help by expanding with a link to the original software and explanation which this plugin is inspired by, but you can just reject the PR, and I will find elsewhere to contribute.

It has nothing to do with that software. That is the whole point.

As you wish, closing.

@frenck frenck closed this Oct 10, 2020
@probot-home-assistant probot-home-assistant Bot added Invalid and removed Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 10, 2020
@IvxLars IvxLars deleted the patch-1 branch October 10, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants